Express 5.0 – Last Push

https://github.com/expressjs/discussions/issues/233
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comments

@UlisesGascon

This issue includes a reference to all the PRs/issues or pending tasks for Express and dependencies needed to finally ship Express@5.

Rules (WIP):

  • If something is completed, just marked
  • If there is a PR/Issue/Discussion please add it (try to use one item)
  • If there is someone taking ownership on it, please add it. Ownership means to be the focal point for it not necessarily the person who makes the final change.
  • If there is no leader, feel free to claim it.
  • If you can no longer lead something, just let others claim it back
  • As this issue can have many comments, feel free to address them and then mark the original comment as "outdated" (details) so it is easier to follow.

If you think that any reference is missing, please edit this comment (@expressjs/express-tc) or reply with a comment if you don't have the permissions.

Pending things (Express):

Pending things (Dependencies):

Pending things (Documentation):

Discussions pending:

New

Under Investigation

Decisions made:

Not in 5.x

Future Minors

The text was updated successfully, but these errors were encountered:

jcamiel, mmmeff, skyddyyu, kalmigs, ahmaduxui, siygle, kenrick95, karolis-sh, LEI, wobsoriano, and 5 more reacted with thumbs up emoji wesleytodd, jonchurch, sepehr-mohseni, mertcanaltin, dderevjanik, vuki656, ymeskini, KnlnKS, frankdejonge, mmmeff, and 19 more reacted with heart emoji jonchurch, sepehr-mohseni, mertcanaltin, dderevjanik, vuki656, ymeskini, hilmanski, frankdejonge, mmmeff, bartmanskyi, and 14 more reacted with rocket emoji wojtekmaj, sepehr-mohseni, mertcanaltin, vuki656, ymeskini, dashed, mmmeff, LEI, ZuBB, joonhaklee, and 6 more reacted with eyes emoji
All reactions
  • 👍 15 reactions
  • ❤️ 29 reactions
  • 🚀 24 reactions
  • 👀 16 reactions

This was referenced

Apr 24, 2024

@wesleytodd

This comment was marked as outdated.

@UlisesGascon

This comment was marked as outdated.

@CBID2

This comment was marked as outdated.

@wesleytodd

Yeah this is great! Absolutely agree with getting folks involved in taking ownership of them. Go team!

If anything is missing from dependencies, please feel free to add them.

Ok yeah this was my main concern. I knew for sure there is router stuff which is why I started there with the labels, but I think there is more in the other few. So if anyone wants to take point on reviewing the deps we own which are "direct deps" of express that would be awesome. Specifically I think each repo needs to address if there are any pending breaking changes which look like they were ready to land (if they are too contentious or too incomplete then we should not land them now) or if there is a pre-existing major version branch with work left to do on it (which is the case in a few for sure). For that we need to catalog that work here so we make sure we don't miss anything.

@jonchurch

This comment was marked as resolved.

@mertcanaltin

This comment was marked as outdated.

@mertcanaltin

This comment was marked as outdated.

@UlisesGascon

@wesleytodd

Active dev branch for v5 is 5.x, correct? As opposed to 5.0 which would be a release branch?

Yeah exactly. That said I have gotten confused a few times and I think this is one case where we would benefit from automation and some really clear and simple docs.

@Yaminyam

This comment was marked as off-topic.

@wesleytodd

This comment was marked as off-topic.

@wesleytodd

@wesleytodd

I reviewed the remaining open things in body-parser. I added them to the list here, but likely will want to update the linked v2 PR as well. I dont have enough remaining battery on this plane to be able to start work on them, and also I think some are a bit ambigious as to what we need to do to get it across the finish line. Would love if folks could click through some of the ones I added and add any insight or thoughts they have on them and if we need to land them.

This was referenced

May 30, 2024

This was referenced

Jun 13, 2024

@jdhiro

This comment was marked as abuse.

@RobinTail

@wesleytodd , would it be possible to detach features from the breaking changes needed for those features in order to speed up the release of 5.0?

The brotli support could be a feature of 5.1, isn't it? While dropping Node versions below 18 must be prioritised to enable and ease implementing new features of 5.x.

It's been 10 years.

2024-07-03_11-30-59

@ctcpip

A number of things have been punted from the initial 5.0 release, and more may yet be punted, where possible.

This was referenced

Jul 11, 2024

This was referenced

Jul 23, 2024

This was referenced

Jul 25, 2024

@wesleytodd

Ok, I just checked off an important one: "Look through the direct deps to see if they have things which need to land"

I have gone through and commented on or resolved as many of the PR's/issues/discussions in the direct and transitives which seem to have some pending (breaking) changes to land. I added a few things on the list, but they are relatively small and should be simple enough to resolve.

Which means, this is pretty much a complete final picture finally of what needs to be wrapped up to release.

This was referenced

Aug 8, 2024

@IamLizu

This comment was marked as resolved.

@kibertoad

This comment was marked as off-topic.

@wesleytodd

This comment was marked as off-topic.

@RobinTail

stephanebruckert, UlisesGascon, kirillgroshkov, LinusU, and mertcanaltin reacted with hooray emoji Delapouite, lin72h, mertcanaltin, IamLizu, stephanebruckert, wesleytodd, UlisesGascon, ctcpip, kirillgroshkov, and LinusU reacted with heart emoji IamLizu, stephanebruckert, wesleytodd, UlisesGascon, kirillgroshkov, derhuerst, LinusU, and mertcanaltin reacted with rocket emoji
All reactions
  • 🎉 5 reactions
  • ❤️ 10 reactions
  • 🚀 8 reactions

@wesleytodd

We put a closes line in the commit, but looks like it didnt actually close this. So I can happily say this is closed as completed!

@UlisesGascon

I will relocate the pending things to 2 new issues (backlog for 5.x and Backlog for 6.0) :)

@ctcpip

{
"by": "rareitem",
"descendants": 17,
"id": 40218896,
"kids": [
40219347,
40219431,
40219059,
40219199
],
"score": 40,
"time": 1714530487,
"title": "Express 5.0 – Last Push",
"type": "story",
"url": "https://github.com/expressjs/discussions/issues/233"
}
{
"author": "expressjs",
"date": "2024-04-24T12:00:00.000Z",
"description": "This issue includes a reference to all the PRs/issues or pending tasks for Express and dependencies needed to finally ship Express@5. Rules (WIP): If something is completed, just marked If there is…",
"image": "https://opengraph.githubassets.com/86a2b7fb61ab60778a6b8bf969684c657d8be19cf607ed25a7d146932b9ea98f/expressjs/discussions/issues/233",
"logo": "https://logo.clearbit.com/github.com",
"publisher": "GitHub",
"title": "Express 5.0 - last push! · Issue #233 · expressjs/discussions",
"url": "https://github.com/expressjs/discussions/issues/233"
}
{
"url": "https://github.com/expressjs/discussions/issues/233",
"title": "Express 5.0 - last push! · Issue #233 · expressjs/discussions",
"description": "This issue includes a reference to all the PRs/issues or pending tasks for Express and dependencies needed to finally ship Express@5. Rules (WIP): If something is completed, just marked If there is...",
"links": [
"https://github.com/expressjs/discussions/issues/233"
],
"image": "https://opengraph.githubassets.com/86a2b7fb61ab60778a6b8bf969684c657d8be19cf607ed25a7d146932b9ea98f/expressjs/discussions/issues/233",
"content": "<div>\n <div>\n<details>\n <summary>\n New issue\n </summary>\n <div>\n <p>\n <strong>Have a question about this project?</strong> Sign up for a free GitHub account to open an issue and contact its maintainers and the community.\n </p>\n <p>By clicking “Sign up for GitHub”, you agree to our <a href=\"https://docs.github.com/terms\" target=\"_blank\">terms of service</a> and\n <a href=\"https://docs.github.com/privacy\" target=\"_blank\">privacy statement</a>. We’ll occasionally send you account related emails.</p>\n <p>\n Already on GitHub?\n <a target=\"_blank\" href=\"https://github.com/login?return_to=%2Fexpressjs%2Fdiscussions%2Fissues%2Fnew%2Fchoose\">Sign in</a>\n to your account\n </p>\n</div>\n</details>\n </div>\n <div> \n<h2>Comments</h2>\n<div>\n <div>\n <p><a target=\"_blank\" href=\"https://github.com/UlisesGascon\"><img src=\"https://avatars.githubusercontent.com/u/5110813?s=80&amp;u=3c41facd8aa26154b9451de237c34b0f78d672a5&amp;v=4\" alt=\"@UlisesGascon\" /></a>\n</p>\n <div>\n<table>\n <tbody>\n <tr>\n <td>\n <p>This issue includes a reference to all the PRs/issues or pending tasks for Express and dependencies needed to finally ship Express@5.</p>\n<h3>Rules (WIP):</h3>\n<ul>\n<li>If something is completed, just marked</li>\n<li>If there is a PR/Issue/Discussion please add it (try to use one item)</li>\n<li>If there is someone taking ownership on it, please add it. Ownership means to be the focal point for it not necessarily the person who makes the final change.</li>\n<li>If there is no leader, feel free to claim it.</li>\n<li>If you can no longer lead something, just let others claim it back</li>\n<li>As this issue can have many comments, feel free to address them and then mark the original comment as \"outdated\" (<a target=\"_blank\" href=\"https://docs.github.com/en/communities/moderating-comments-and-conversations/managing-disruptive-comments#hiding-a-comment\">details</a>) so it is easier to follow.</li>\n</ul>\n<p>If you think that any reference is missing, please edit this comment (@expressjs/express-tc) or reply with a comment if you don't have the permissions.</p>\n<h3>Pending things (Express):</h3>\n<ul>\n<li> <span><a target=\"_blank\" href=\"https://github.com/expressjs/express/pull/5627\">add support Node.js@22 in the CI<span> express#5627</span></a></span> (<a target=\"_blank\" href=\"https://github.com/mertcanaltin\">@mertcanaltin</a>)</li>\n<li> <span><a target=\"_blank\" href=\"https://github.com/expressjs/express/pull/5595\">Adopt Node@18 as the minimum supported version<span> express#5595</span></a></span> (<a target=\"_blank\" href=\"https://github.com/UlisesGascon\">@UlisesGascon</a> )</li>\n<li> <span><a target=\"_blank\" href=\"https://github.com/expressjs/express/pull/4861\">Use object with null prototype for various app properties<span> express#4861</span></a></span></li>\n<li> <span><a target=\"_blank\" href=\"https://github.com/expressjs/express/pull/5792\">Ignore <code>expires</code> and <code>maxAge</code> in <code>res.clearCookie()</code><span> express#5792</span></a></span> (<a target=\"_blank\" href=\"https://github.com/jonchurch\">@jonchurch</a>)</li>\n<li> <span><a target=\"_blank\" href=\"https://github.com/expressjs/express/pull/4835\">Use object with null prototype for settings<span> express#4835</span></a></span></li>\n<li> <span><a target=\"_blank\" href=\"https://github.com/expressjs/express/pull/4212\">Throw on invalid status codes<span> express#4212</span></a></span> (<a target=\"_blank\" href=\"https://github.com/jonchurch\">@jonchurch</a>)</li>\n<li> <span><a target=\"_blank\" href=\"https://github.com/expressjs/express/pull/3216\">Call callback once on listen error<span> express#3216</span></a></span> (<a target=\"_blank\" href=\"https://github.com/wesleytodd\">@wesleytodd</a>)</li>\n<li> <span><a target=\"_blank\" href=\"https://github.com/expressjs/expressjs.com/issues/1464\">Update 5.0 version in Migration Guide<span> expressjs.com#1464</span></a></span> (<a target=\"_blank\" href=\"https://github.com/crandmck\">@crandmck</a>)</li>\n<li> <span><a target=\"_blank\" href=\"https://github.com/expressjs/expressjs.com/issues/1408\">express 5 router wildcard does not work as documented<span> expressjs.com#1408</span></a></span> (<a target=\"_blank\" href=\"https://github.com/blakeembrey\">@blakeembrey</a> )</li>\n<li> <span><a target=\"_blank\" href=\"https://github.com/expressjs/express/pull/5677\">Use Array.flat instead of array-flatten<span> express#5677</span></a></span> (<a target=\"_blank\" href=\"https://github.com/UlisesGascon\">@UlisesGascon</a> )</li>\n<li> <span><a target=\"_blank\" href=\"https://github.com/expressjs/discussions/issues/256\">List of dependencies to upgrade<span> #256</span></a></span> (<a target=\"_blank\" href=\"https://github.com/UlisesGascon\">@UlisesGascon</a> / <a target=\"_blank\" href=\"https://github.com/IamLizu\">@IamLizu</a>)</li>\n</ul>\n<h3>Pending things (Dependencies):</h3>\n<ul>\n<li> <span><a target=\"_blank\" href=\"https://github.com/expressjs/express/pull/5885\">router@^2.0.0<span> express#5885</span></a></span> (<a target=\"_blank\" href=\"https://github.com/wesleytodd\">@wesleytodd</a>)\n<ul>\n<li> <span><a target=\"_blank\" href=\"https://github.com/pillarjs/router/pull/117\">path-to-regexp@^8.0.0<span> pillarjs/router#117</span></a></span></li>\n<li> <span><a target=\"_blank\" href=\"https://github.com/pillarjs/router/pull/60\">Release 2.0<span> pillarjs/router#60</span></a></span></li>\n</ul>\n</li>\n<li> <span><a target=\"_blank\" href=\"https://github.com/expressjs/body-parser/pull/66\">Release 2.0<span> body-parser#66</span></a></span> (<a target=\"_blank\" href=\"https://github.com/wesleytodd\">@wesleytodd</a>)</li>\n<li> <span><a target=\"_blank\" href=\"https://github.com/expressjs/body-parser/pull/406\">Added support for brotli ('br') content-encoding<span> body-parser#406</span></a></span> (<a target=\"_blank\" href=\"https://github.com/wesleytodd\">@wesleytodd</a> or <a target=\"_blank\" href=\"https://github.com/UlisesGascon\">@UlisesGascon</a> or TBD)</li>\n<li> <span><a target=\"_blank\" href=\"https://github.com/expressjs/body-parser/pull/387\">Also use the qs module for the simple parser<span> body-parser#387</span></a></span> (<a target=\"_blank\" href=\"https://github.com/wesleytodd\">@wesleytodd</a>)</li>\n<li> <span><a target=\"_blank\" href=\"https://github.com/expressjs/body-parser/pull/326\">urlencoded: Support iso-8859-1, utf8 sentinel, and numeric entities<span> body-parser#326</span></a></span> (<a target=\"_blank\" href=\"https://github.com/wesleytodd\">@wesleytodd</a>)</li>\n<li> <span><a target=\"_blank\" href=\"https://github.com/pillarjs/send/pull/208\">Release 1.0<span> pillarjs/send#208</span></a></span> (<a target=\"_blank\" href=\"https://github.com/blakeembrey\">@blakeembrey</a> or <a target=\"_blank\" href=\"https://github.com/wesleytodd\">@wesleytodd</a> its a race)</li>\n<li> <span><a target=\"_blank\" href=\"https://github.com/expressjs/serve-static/pull/165\">Release 2.0<span> serve-static#165</span></a></span> (<a target=\"_blank\" href=\"https://github.com/wesleytodd\">@wesleytodd</a>)</li>\n<li> <span><a target=\"_blank\" href=\"https://github.com/jshttp/mime-types/pull/129\">Release: 3.0<span> jshttp/mime-types#129</span></a></span> (<a target=\"_blank\" href=\"https://github.com/wesleytodd\">@wesleytodd</a>)\n<ul>\n<li> <span><a target=\"_blank\" href=\"https://github.com/expressjs/express/pull/5882\">mime-types@3<span> express#5882</span></a></span></li>\n<li> <span><a target=\"_blank\" href=\"https://github.com/expressjs/express/pull/5881\">accepts@2<span> express#5881</span></a></span></li>\n<li> <span><a target=\"_blank\" href=\"https://github.com/expressjs/express/pull/5883\">type-is@^2.0.0<span> express#5883</span></a></span></li>\n</ul>\n</li>\n<li> <span><a target=\"_blank\" href=\"https://github.com/expressjs/express/pull/5899\">fix(deps): finalhandler@^2.0.0<span> express#5899</span></a></span>\n<ul>\n<li> <span><a target=\"_blank\" href=\"https://github.com/pillarjs/finalhandler/pull/55\">2.x Staging PR<span> pillarjs/finalhandler#55</span></a></span></li>\n<li> <span><a target=\"_blank\" href=\"https://github.com/pillarjs/finalhandler/pull/57\">fix: gracefully handle when handling an error and socket is null<span> pillarjs/finalhandler#57</span></a></span></li>\n</ul>\n</li>\n<li> <span><a target=\"_blank\" href=\"https://github.com/jshttp/fresh/pull/38\">Fix: Expect return true immediately if If-None-Match matches the ETag header (#35)<span> jshttp/fresh#38</span></a></span> (<a target=\"_blank\" href=\"https://github.com/jonchurch\">@jonchurch</a>)</li>\n<li> Look through the direct deps to see if they have things which need to land,, or releases to cut, untracked WORK! (<a target=\"_blank\" href=\"https://github.com/wesleytodd\">@wesleytodd</a>)</li>\n<li> Ensure each of the dependencies updates their transitives</li>\n</ul>\n<h3>Pending things (Documentation):</h3>\n<ul>\n<li> <span><a target=\"_blank\" href=\"https://github.com/expressjs/expressjs.com/issues/1483\">Add blog<span> expressjs.com#1483</span></a></span> It will great to do an announcement in the blog about the release and celebrate this big milestone for the project 🥳 (<a target=\"_blank\" href=\"https://github.com/UlisesGascon\">@UlisesGascon</a> )</li>\n<li> <span><a target=\"_blank\" href=\"https://github.com/expressjs/expressjs.com/issues/1466\">Update security and performance best practices<span> expressjs.com#1466</span></a></span> Should be offer a fresh version when v5 is ready? (<a target=\"_blank\" href=\"https://github.com/UlisesGascon\">@UlisesGascon</a> )</li>\n<li> <span><a target=\"_blank\" href=\"https://github.com/expressjs/expressjs.com/issues/1479\">Review and Update v5.x Documentation against v4.x<span> expressjs.com#1479</span></a></span> (<a target=\"_blank\" href=\"https://github.com/UlisesGascon\">@UlisesGascon</a> )</li>\n</ul>\n<h3>Discussions pending:</h3>\n<p><strong>New</strong></p>\n<ul>\n<li> Express Generator? <a target=\"_blank\" href=\"https://github.com/expressjs/discussions/issues/233#issuecomment-2102971156\">Context</a></li>\n</ul>\n<p><strong>Under Investigation</strong></p>\n<ul>\n<li> <span><a target=\"_blank\" href=\"https://github.com/expressjs/express/pull/2692\">Cleaner way for redirecting back to the Referrer<span> express#2692</span></a></span> (<a target=\"_blank\" href=\"https://github.com/blakeembrey\">@blakeembrey</a> )</li>\n<li> <span><a target=\"_blank\" href=\"https://github.com/expressjs/express/pull/2653\">Resolve paths for views asynchronously<span> express#2653</span></a></span> (<a target=\"_blank\" href=\"https://github.com/blakeembrey\">@blakeembrey</a> )</li>\n</ul>\n<h3>Decisions made:</h3>\n<p><strong>Not in 5.x</strong></p>\n<ul>\n<li> <span><a target=\"_blank\" href=\"https://github.com/expressjs/express/pull/3730\">Support http/2.<span> express#3730</span></a></span></li>\n<li> <span><a target=\"_blank\" href=\"https://github.com/expressjs/express/pull/3214\">Moves req/res out of the repo<span> express#3214</span></a></span></li>\n<li> <span><a target=\"_blank\" href=\"https://github.com/expressjs/express/pull/3218\">Settings functionality moved out of core<span> express#3218</span></a></span></li>\n<li> <span><a target=\"_blank\" href=\"https://github.com/expressjs/express/pull/3213\">Remove direct http dependency<span> express#3213</span></a></span></li>\n<li> <span><a target=\"_blank\" href=\"https://github.com/expressjs/express/pull/2648\">separate locals from config values<span> express#2648</span></a></span></li>\n<li> <span><a target=\"_blank\" href=\"https://github.com/expressjs/body-parser/pull/524\">rebase: Generic Body Parser implemented<span> body-parser#524</span></a></span></li>\n<li> <span><a target=\"_blank\" href=\"https://github.com/jshttp/on-finished/pull/31\">response is only finished if socket is detached<span> jshttp/on-finished#31</span></a></span> (<a target=\"_blank\" href=\"https://github.com/UlisesGascon\">@UlisesGascon</a>)</li>\n</ul>\n<p><strong>Future Minors</strong></p>\n<ul>\n<li> <span><a target=\"_blank\" href=\"https://github.com/expressjs/express/pull/5856\">feat(response): new setting strict status codes<span> express#5856</span></a></span> (<a target=\"_blank\" href=\"https://github.com/aagamezl\">@aagamezl</a>)</li>\n<li> <span><a target=\"_blank\" href=\"https://github.com/expressjs/express/pull/5492\">New Integration tests (example split continuation)<span> express#5492</span></a></span> (<a target=\"_blank\" href=\"https://github.com/UlisesGascon\">@UlisesGascon</a> )</li>\n<li> <span><a target=\"_blank\" href=\"https://github.com/expressjs/express/pull/3259\">Moves compileQueryParser to separate module<span> express#3259</span></a></span> (<a target=\"_blank\" href=\"https://github.com/wesleytodd\">@wesleytodd</a>)</li>\n</ul>\n </td>\n </tr>\n <tr>\n <td>\n <div>\n <p>\n The text was updated successfully, but these errors were encountered:\n </p>\n <ol>\n </ol>\n </div>\n </td>\n </tr>\n </tbody>\n</table>\n <div>\n <div>\n jcamiel, mmmeff, skyddyyu, kalmigs, ahmaduxui, siygle, kenrick95, karolis-sh, LEI, wobsoriano, and 5 more reacted with thumbs up emoji\n wesleytodd, jonchurch, sepehr-mohseni, mertcanaltin, dderevjanik, vuki656, ymeskini, KnlnKS, frankdejonge, mmmeff, and 19 more reacted with heart emoji\n jonchurch, sepehr-mohseni, mertcanaltin, dderevjanik, vuki656, ymeskini, hilmanski, frankdejonge, mmmeff, bartmanskyi, and 14 more reacted with rocket emoji\n wojtekmaj, sepehr-mohseni, mertcanaltin, vuki656, ymeskini, dashed, mmmeff, LEI, ZuBB, joonhaklee, and 6 more reacted with eyes emoji\n <div>\n <details>\n <summary> <span>\n <span>All reactions</span>\n </span>\n</summary>\n <ul>\n <li>\n 👍\n <span>15 reactions</span>\n </li>\n <li>\n ❤️\n <span>29 reactions</span>\n </li>\n <li>\n 🚀\n <span>24 reactions</span>\n </li>\n <li>\n 👀\n <span>16 reactions</span>\n </li>\n </ul>\n </details>\n </div>\n </div>\n</div>\n </div>\n</div>\n <div>\n <div><p>\n This was referenced </p>Apr 24, 2024\n</div>\n <div>\n <p><a target=\"_blank\" href=\"https://github.com/wesleytodd\"><img src=\"https://avatars.githubusercontent.com/u/1027776?s=80&amp;v=4\" alt=\"@wesleytodd\" /></a>\n</p>\n <div>\n <details>\n <summary>\n <div>\n <h3>\n This comment was marked as outdated.\n </h3>\n </div>\n </summary>\n </details>\n </div>\n</div>\n <div>\n <p><a target=\"_blank\" href=\"https://github.com/UlisesGascon\"><img src=\"https://avatars.githubusercontent.com/u/5110813?s=80&amp;u=3c41facd8aa26154b9451de237c34b0f78d672a5&amp;v=4\" alt=\"@UlisesGascon\" /></a>\n</p>\n <div>\n <details>\n <summary>\n <div>\n <h3>\n This comment was marked as outdated.\n </h3>\n </div>\n </summary>\n </details>\n </div>\n</div>\n <div>\n <p><a target=\"_blank\" href=\"https://github.com/CBID2\"><img src=\"https://avatars.githubusercontent.com/u/105683440?s=80&amp;u=fa3168b8b1e165909aa7ad6a09adfcd6ead45def&amp;v=4\" alt=\"@CBID2\" /></a>\n</p>\n <div>\n <details>\n <summary>\n <div>\n <h3>\n This comment was marked as outdated.\n </h3>\n </div>\n </summary>\n </details>\n </div>\n</div>\n <div>\n <p><a target=\"_blank\" href=\"https://github.com/wesleytodd\"><img src=\"https://avatars.githubusercontent.com/u/1027776?s=80&amp;v=4\" alt=\"@wesleytodd\" /></a>\n</p>\n <div>\n<div>\n <p>Yeah this is great! Absolutely agree with getting folks involved in taking ownership of them. Go team!</p>\n<blockquote>\n<p>If anything is missing from dependencies, please feel free to add them.</p>\n</blockquote>\n<p>Ok yeah this was my main concern. I knew for sure there is router stuff which is why I started there with the labels, but I think there is more in the other few. So if anyone wants to take point on reviewing the deps we own which are \"direct deps\" of <code>express</code> that would be awesome. Specifically I think each repo needs to address if there are any pending breaking changes which look like they were ready to land (if they are too contentious or too incomplete then we should not land them now) or if there is a pre-existing major version branch with work left to do on it (which is the case in a few for sure). For that we need to catalog that work here so we make sure we don't miss anything.</p>\n </div>\n </div>\n</div>\n <div>\n <p><a target=\"_blank\" href=\"https://github.com/jonchurch\"><img src=\"https://avatars.githubusercontent.com/u/12915163?s=80&amp;u=5676e00f9b4097423d907c900338a61a5ae6cf56&amp;v=4\" alt=\"@jonchurch\" /></a>\n</p>\n <div>\n <details>\n <summary>\n <div>\n <h3>\n This comment was marked as resolved.\n </h3>\n </div>\n </summary>\n </details>\n </div>\n</div>\n <div>\n <p><a target=\"_blank\" href=\"https://github.com/mertcanaltin\"><img src=\"https://avatars.githubusercontent.com/u/37827216?s=80&amp;u=36c22719569f7e3fd3fc8ab0ad8da8d7815b4306&amp;v=4\" alt=\"@mertcanaltin\" /></a>\n</p>\n <div>\n <details>\n <summary>\n <div>\n <h3>\n This comment was marked as outdated.\n </h3>\n </div>\n </summary>\n </details>\n </div>\n</div>\n <div>\n <p><a target=\"_blank\" href=\"https://github.com/mertcanaltin\"><img src=\"https://avatars.githubusercontent.com/u/37827216?s=80&amp;u=36c22719569f7e3fd3fc8ab0ad8da8d7815b4306&amp;v=4\" alt=\"@mertcanaltin\" /></a>\n</p>\n <div>\n <details>\n <summary>\n <div>\n <h3>\n This comment was marked as outdated.\n </h3>\n </div>\n </summary>\n </details>\n </div>\n</div>\n <div>\n <p><a target=\"_blank\" href=\"https://github.com/UlisesGascon\"><img src=\"https://avatars.githubusercontent.com/u/5110813?s=80&amp;u=3c41facd8aa26154b9451de237c34b0f78d672a5&amp;v=4\" alt=\"@UlisesGascon\" /></a>\n</p>\n</div>\n <div>\n <p><a target=\"_blank\" href=\"https://github.com/wesleytodd\"><img src=\"https://avatars.githubusercontent.com/u/1027776?s=80&amp;v=4\" alt=\"@wesleytodd\" /></a>\n</p>\n <div>\n<div>\n <blockquote>\n<p>Active dev branch for v5 is <a target=\"_blank\" href=\"https://github.com/expressjs/express/tree/5.x\">5.x</a>, correct? As opposed to 5.0 which would be a release branch?</p>\n</blockquote>\n<p>Yeah exactly. That said I have gotten confused a few times and I think this is one case where we would benefit from automation and some really clear and simple docs.</p>\n </div>\n </div>\n</div>\n <div>\n <p><a target=\"_blank\" href=\"https://github.com/Yaminyam\"><img src=\"https://avatars.githubusercontent.com/u/31057849?s=80&amp;u=d56518785909edee402d55107e8134938666d659&amp;v=4\" alt=\"@Yaminyam\" /></a>\n</p>\n <div>\n <details>\n <summary>\n <div>\n <h3>\n This comment was marked as off-topic.\n </h3>\n </div>\n </summary>\n </details>\n </div>\n</div>\n <div>\n <p><a target=\"_blank\" href=\"https://github.com/wesleytodd\"><img src=\"https://avatars.githubusercontent.com/u/1027776?s=80&amp;v=4\" alt=\"@wesleytodd\" /></a>\n</p>\n <div>\n <details>\n <summary>\n <div>\n <h3>\n This comment was marked as off-topic.\n </h3>\n </div>\n </summary>\n </details>\n </div>\n</div>\n <div>\n <p><a target=\"_blank\" href=\"https://github.com/wesleytodd\"><img src=\"https://avatars.githubusercontent.com/u/1027776?s=80&amp;v=4\" alt=\"@wesleytodd\" /></a>\n</p>\n</div>\n <div>\n <p><a target=\"_blank\" href=\"https://github.com/wesleytodd\"><img src=\"https://avatars.githubusercontent.com/u/1027776?s=80&amp;v=4\" alt=\"@wesleytodd\" /></a>\n</p>\n <div>\n<div>\n <p>I reviewed the remaining open things in <code>body-parser</code>. I added them to the list here, but likely will want to update the linked v2 PR as well. I dont have enough remaining battery on this plane to be able to start work on them, and also I think some are a bit ambigious as to what we need to do to get it across the finish line. Would love if folks could click through some of the ones I added and add any insight or thoughts they have on them and if we need to land them.</p>\n </div>\n </div>\n</div>\n <div>\n <div><p>\n This was referenced </p>May 30, 2024\n</div>\n <div><p>\n This was referenced </p>Jun 13, 2024\n</div>\n</div>\n <div>\n <p><a target=\"_blank\" href=\"https://github.com/jdhiro\"><img src=\"https://avatars.githubusercontent.com/u/2919453?s=80&amp;u=02dc0662720d9f5536afb6b710640556ec7df3e2&amp;v=4\" alt=\"@jdhiro\" /></a>\n</p>\n <div>\n <details>\n <summary>\n <div>\n <h3>\n This comment was marked as abuse.\n </h3>\n </div>\n </summary>\n </details>\n </div>\n</div>\n <div>\n <p><a target=\"_blank\" href=\"https://github.com/RobinTail\"><img src=\"https://avatars.githubusercontent.com/u/13189514?s=80&amp;u=d63ece1af1162a6cb455e2218c8c82cdd97c5aad&amp;v=4\" alt=\"@RobinTail\" /></a>\n</p>\n <div>\n<div>\n <p><a target=\"_blank\" href=\"https://github.com/wesleytodd\">@wesleytodd</a> , would it be possible to detach features from the breaking changes needed for those features in order to speed up the release of <code>5.0</code>?</p>\n<p>The <code>brotli</code> support could be a feature of <code>5.1</code>, isn't it? While dropping Node versions below 18 must be prioritised to enable and ease implementing new features of <code>5.x</code>.</p>\n<p>It's been 10 years.</p>\n<p><a target=\"_blank\" href=\"https://private-user-images.githubusercontent.com/13189514/345366579-4d298449-0c58-4ad8-93c5-42f68b95574b.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzIxOTQyNjYsIm5iZiI6MTczMjE5Mzk2NiwicGF0aCI6Ii8xMzE4OTUxNC8zNDUzNjY1NzktNGQyOTg0NDktMGM1OC00YWQ4LTkzYzUtNDJmNjhiOTU1NzRiLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDExMjElMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQxMTIxVDEyNTkyNlomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWIwMzA3MjQ1N2VjMGUwNmIwNDQ2MjNmYzBmMGRjYjRiMDQ1MjBjYmM0ZWVhYTBjOTQyZGM4MmVmZjkyMzgyOGMmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.znaoHo64MclYy_uMYtfeca_Q5nj_s_Wg6QRAyUx0iiI\"><img src=\"https://private-user-images.githubusercontent.com/13189514/345366579-4d298449-0c58-4ad8-93c5-42f68b95574b.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzIxOTQyNjYsIm5iZiI6MTczMjE5Mzk2NiwicGF0aCI6Ii8xMzE4OTUxNC8zNDUzNjY1NzktNGQyOTg0NDktMGM1OC00YWQ4LTkzYzUtNDJmNjhiOTU1NzRiLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDExMjElMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQxMTIxVDEyNTkyNlomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWIwMzA3MjQ1N2VjMGUwNmIwNDQ2MjNmYzBmMGRjYjRiMDQ1MjBjYmM0ZWVhYTBjOTQyZGM4MmVmZjkyMzgyOGMmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.znaoHo64MclYy_uMYtfeca_Q5nj_s_Wg6QRAyUx0iiI\" alt=\"2024-07-03_11-30-59\" /></a></p>\n </div>\n </div>\n</div>\n <div>\n <p><a target=\"_blank\" href=\"https://github.com/ctcpip\"><img src=\"https://avatars.githubusercontent.com/u/15326526?s=80&amp;u=813f9e9a6c9506ef7612ad8ed414abcc03498a4f&amp;v=4\" alt=\"@ctcpip\" /></a>\n</p>\n <div>\n<div>\n <p>A number of things have been punted from the initial <code>5.0</code> release, and more may yet be punted, where possible.</p>\n </div>\n </div>\n</div>\n <div>\n <div><p>\n This was referenced </p>Jul 11, 2024\n</div>\n <div><p>\n This was referenced </p>Jul 23, 2024\n</div>\n <div><p>\n This was referenced </p>Jul 25, 2024\n</div>\n</div>\n <div>\n <p><a target=\"_blank\" href=\"https://github.com/wesleytodd\"><img src=\"https://avatars.githubusercontent.com/u/1027776?s=80&amp;v=4\" alt=\"@wesleytodd\" /></a>\n</p>\n <div>\n<div>\n <p>Ok, I just checked off an important one: \"Look through the direct deps to see if they have things which need to land\"</p>\n<p>I have gone through and commented on or resolved as many of the PR's/issues/discussions in the direct and transitives which seem to have some pending (breaking) changes to land. I added a few things on the list, but they are relatively small and should be simple enough to resolve.</p>\n<p>Which means, this is pretty much a complete final picture finally of what needs to be wrapped up to release.</p>\n </div>\n </div>\n</div>\n <div><p>\n This was referenced </p>Aug 8, 2024\n</div>\n <div>\n <p><a target=\"_blank\" href=\"https://github.com/IamLizu\"><img src=\"https://avatars.githubusercontent.com/u/26184316?s=80&amp;u=088a4e15de2892f83de874b69285ec68717ce6e4&amp;v=4\" alt=\"@IamLizu\" /></a>\n</p>\n <div>\n <details>\n <summary>\n <div>\n <h3>\n This comment was marked as resolved.\n </h3>\n </div>\n </summary>\n </details>\n </div>\n</div>\n <div>\n <p><a target=\"_blank\" href=\"https://github.com/kibertoad\"><img src=\"https://avatars.githubusercontent.com/u/1847934?s=80&amp;u=c2b2f6633e0a92681474680c64cda1bf7d0500de&amp;v=4\" alt=\"@kibertoad\" /></a>\n</p>\n <div>\n <details>\n <summary>\n <div>\n <h3>\n This comment was marked as off-topic.\n </h3>\n </div>\n </summary>\n </details>\n </div>\n</div>\n <div>\n <p><a target=\"_blank\" href=\"https://github.com/wesleytodd\"><img src=\"https://avatars.githubusercontent.com/u/1027776?s=80&amp;v=4\" alt=\"@wesleytodd\" /></a>\n</p>\n <div>\n <details>\n <summary>\n <div>\n <h3>\n This comment was marked as off-topic.\n </h3>\n </div>\n </summary>\n </details>\n </div>\n</div>\n <div>\n <p><a target=\"_blank\" href=\"https://github.com/RobinTail\"><img src=\"https://avatars.githubusercontent.com/u/13189514?s=80&amp;u=d63ece1af1162a6cb455e2218c8c82cdd97c5aad&amp;v=4\" alt=\"@RobinTail\" /></a>\n</p>\n <div>\n <div>\n <div>\n stephanebruckert, UlisesGascon, kirillgroshkov, LinusU, and mertcanaltin reacted with hooray emoji\n Delapouite, lin72h, mertcanaltin, IamLizu, stephanebruckert, wesleytodd, UlisesGascon, ctcpip, kirillgroshkov, and LinusU reacted with heart emoji\n IamLizu, stephanebruckert, wesleytodd, UlisesGascon, kirillgroshkov, derhuerst, LinusU, and mertcanaltin reacted with rocket emoji\n <div>\n <details>\n <summary> <span>\n <span>All reactions</span>\n </span>\n</summary>\n <ul>\n <li>\n 🎉\n <span>5 reactions</span>\n </li>\n <li>\n ❤️\n <span>10 reactions</span>\n </li>\n <li>\n 🚀\n <span>8 reactions</span>\n </li>\n </ul>\n </details>\n </div>\n </div>\n</div>\n </div>\n</div>\n <div>\n <p><a target=\"_blank\" href=\"https://github.com/wesleytodd\"><img src=\"https://avatars.githubusercontent.com/u/1027776?s=80&amp;v=4\" alt=\"@wesleytodd\" /></a>\n</p>\n <div>\n<div>\n <p>We put a closes line in the commit, but looks like it didnt actually close this. So I can happily say this is closed as completed!</p>\n </div>\n </div>\n</div>\n <div>\n <p><a target=\"_blank\" href=\"https://github.com/UlisesGascon\"><img src=\"https://avatars.githubusercontent.com/u/5110813?s=80&amp;u=3c41facd8aa26154b9451de237c34b0f78d672a5&amp;v=4\" alt=\"@UlisesGascon\" /></a>\n</p>\n <div>\n<div>\n <p>I will relocate the pending things to 2 new issues (backlog for 5.x and Backlog for 6.0) :)</p>\n </div>\n </div>\n</div>\n <div>\n <p><a target=\"_blank\" href=\"https://github.com/ctcpip\"><img src=\"https://avatars.githubusercontent.com/u/15326526?s=80&amp;u=813f9e9a6c9506ef7612ad8ed414abcc03498a4f&amp;v=4\" alt=\"@ctcpip\" /></a>\n</p>\n</div>\n</div>\n </div>\n</div>\n </div>",
"author": "",
"favicon": "https://github.githubassets.com/favicons/favicon.svg",
"source": "github.com",
"published": "",
"ttr": 276,
"type": "object"
}