Express 5.0 – Last Push
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
All reactions
- 👍 15 reactions
- ❤️ 29 reactions
- 🚀 24 reactions
- 👀 16 reactions
This was referenced
Apr 24, 2024Yeah this is great! Absolutely agree with getting folks involved in taking ownership of them. Go team!
If anything is missing from dependencies, please feel free to add them.
Ok yeah this was my main concern. I knew for sure there is router stuff which is why I started there with the labels, but I think there is more in the other few. So if anyone wants to take point on reviewing the deps we own which are "direct deps" of express
that would be awesome. Specifically I think each repo needs to address if there are any pending breaking changes which look like they were ready to land (if they are too contentious or too incomplete then we should not land them now) or if there is a pre-existing major version branch with work left to do on it (which is the case in a few for sure). For that we need to catalog that work here so we make sure we don't miss anything.
Active dev branch for v5 is 5.x, correct? As opposed to 5.0 which would be a release branch?
Yeah exactly. That said I have gotten confused a few times and I think this is one case where we would benefit from automation and some really clear and simple docs.
I reviewed the remaining open things in body-parser
. I added them to the list here, but likely will want to update the linked v2 PR as well. I dont have enough remaining battery on this plane to be able to start work on them, and also I think some are a bit ambigious as to what we need to do to get it across the finish line. Would love if folks could click through some of the ones I added and add any insight or thoughts they have on them and if we need to land them.
This was referenced
May 30, 2024This was referenced
Jun 13, 2024@wesleytodd , would it be possible to detach features from the breaking changes needed for those features in order to speed up the release of 5.0
?
The brotli
support could be a feature of 5.1
, isn't it? While dropping Node versions below 18 must be prioritised to enable and ease implementing new features of 5.x
.
It's been 10 years.
A number of things have been punted from the initial 5.0
release, and more may yet be punted, where possible.
This was referenced
Jul 11, 2024This was referenced
Jul 23, 2024This was referenced
Jul 25, 2024Ok, I just checked off an important one: "Look through the direct deps to see if they have things which need to land"
I have gone through and commented on or resolved as many of the PR's/issues/discussions in the direct and transitives which seem to have some pending (breaking) changes to land. I added a few things on the list, but they are relatively small and should be simple enough to resolve.
Which means, this is pretty much a complete final picture finally of what needs to be wrapped up to release.
This was referenced
Aug 8, 2024All reactions
- 🎉 5 reactions
- ❤️ 10 reactions
- 🚀 8 reactions
We put a closes line in the commit, but looks like it didnt actually close this. So I can happily say this is closed as completed!